Update latest image periodically. #34
Conversation
c-bata
left a comment
c-bata
left a comment
There was a problem hiding this comment.
Changes look almost good to me. I left one minor comment.
.github/workflows/dockerimage.yml
Outdated
| - Dockerfile | ||
| - pyproject.toml | ||
| schedule: | ||
| - cron: '0 23 * * SUN-THU' |
There was a problem hiding this comment.
In my opinion, running this action every weekday is too frequent, since there are no dependency updates in most cases but the Docker image is still rebuilt. How about reducing the frequency to once a week (e.g. every Monday)?
There was a problem hiding this comment.
Thank you for your comment. Sounds reasonable. We'll push the same image again and again according to the recent development velocity of this repository. I'll reduce the frequency to a weekly basis (i.e., 0 23 * * SUN).
There was a problem hiding this comment.
The build is now scheduled for Monday at 8:00 AM JST. See ab62c40.
c-bata
left a comment
c-bata
left a comment
There was a problem hiding this comment.
Thank you for the update. LGTM.
2 participants
Motivation
This PR aims to add scheduled build of docker images. Additionally, it will implement a feature to automatically publish images tagged with
lateston a daily basis.Although Optuna V4.5 was released two weeks ago, this repository lacks an automated mechanism to update dependencies, so the
optuna-mcp:latestimage continues to use Optuna V4.4.Description of the changes
scheduletriggerlatestimage with the schedule triggerreleaseandpull_requesttriggers into distinct steps